Mechanical Edits/Mateusz Konieczny - bot account/fix descriptive names on natural monuments in Poland

From OpenStreetMap Wiki
Jump to navigation Jump to search

Page content created as advised on Automated_Edits_code_of_conduct#Document_and_discuss_your_plans.

Who

I, Mateusz Konieczny using my bot account

contact

message via OSM I will respond also to PMs to the bot account. In both cases I will be notified about incoming PMs via email and notifications in OSM editors.

What

Removing descriptive names on denotation=natural_monument

Why

Descriptive names repeating tags are not wanted and should be removed.

Numbers

Large enough so bot edit makes sense and manual fixing would be a drudgery.

How

  • Editing is limited to objects with denotation=natural_monument
  • Editing is limited to objects with name=Pomnik przyrody tag
  • Editing is limited to objects in Poland.

state before a mechanical edit (example based on https://www.openstreetmap.org/node/4037117496/history ):

state after a mechanical edit:

Bot source code

Bot is using https://github.com/matkoniecz/osm_bot_abstraction_layer library, this code is GNU GPLv3 licensed

from osm_bot_abstraction_layer.generic_bot_retagging import run_simple_retagging_task

def is_element_editable(tag_dictionary, identifier):
    return False

def edit_element(tags):
    if tags.get('natural') not in ["tree", "cave_entrance", "rock", "tree_row", "spring"]:
        print("unexpected natural tag value: ", tags.get('natural'))
        return tags
    if tags.get('denotation') != ("natural_monument"):
        print("unexpected denotation tag value: ", tags.get('denotation'))
        return tags

    if tags.get('name') == ("Pomnik przyrody"):
        tags.pop('name', None)
    return tags

def main():
    run_simple_retagging_task(
        max_count_of_elements_in_one_changeset=500,
        objects_to_consider_query="""
[out:xml][timeout:25000];
area[name="Polska"]->.a;
(
  nwr[name='Pomnik przyrody'][denotation='natural_monument'](area.a);
);
out body;
out skel qt;
""",
        objects_to_consider_query_storage_file='/media/mateusz/OSM_cache/osm_bot_cache/tags_for_retagging_descriptive_monument.osm',
        is_in_manual_mode=False,
        changeset_comment='usuwanie nazw opisowych z pomników przyrody (name="Pomnik przyrody" tam gdzie jest już denotation=natural_monument). Tag name jest dla nazw, nie dla opisywania obiektów.',
        discussion_url='https://forum.openstreetmap.org/viewtopic.php?id=73663',
        osm_wiki_documentation_page='https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fix_descriptive_names_on_natural_monuments_in_Poland',
        edit_element_function=edit_element,
    )

main()

Discussion

Approved by Polish OSM community at https://forum.openstreetmap.org/viewtopic.php?id=73663

Repetition

This is not a reoccurring edit

Opt-out

Please write at https://forum.openstreetmap.org/viewtopic.php?id=73663 .